4
0
Эх сурвалжийг харах

fix: Honor hide_globally when creating a new feed through the api

TestGetGlobalEntriesEndpoint was failing because CreateFeed ignored HideGlobally, this fixes that.
Pontus Jensen Karlsson 1 жил өмнө
parent
commit
ade412f453

+ 10 - 0
internal/api/api_integration_test.go

@@ -2011,6 +2011,16 @@ func TestGetGlobalEntriesEndpoint(t *testing.T) {
 		t.Fatal(err)
 	}
 
+	feedIDEntry, err := regularUserClient.Feed(feedID)
+
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	if feedIDEntry.HideGlobally != true {
+		t.Fatalf(`Expected feed to have globally_hidden set to true, was false.`)
+	}
+
 	/* Not filtering on GloballyVisible should return all entries */
 	feedEntries, err := regularUserClient.Entries(&miniflux.Filter{FeedID: feedID})
 

+ 1 - 0
internal/reader/handler/handler.go

@@ -169,6 +169,7 @@ func CreateFeed(store *storage.Storage, userID int64, feedCreationRequest *model
 	subscription.BlocklistRules = feedCreationRequest.BlocklistRules
 	subscription.KeeplistRules = feedCreationRequest.KeeplistRules
 	subscription.UrlRewriteRules = feedCreationRequest.UrlRewriteRules
+	subscription.HideGlobally = feedCreationRequest.HideGlobally
 	subscription.EtagHeader = responseHandler.ETag()
 	subscription.LastModifiedHeader = responseHandler.LastModified()
 	subscription.FeedURL = responseHandler.EffectiveURL()