Parcourir la source

fix: unbreak cmd/ctrl/shift click on main nav

Most browsers allow opening links in a new window or new
tab by holding down a modifier key like shift, command,
control (depending on the OS and browser) while clicking a link.

Unconditional event.preventDefault() on click events breaks this functionality.
Márton Salomváry il y a 5 mois
Parent
commit
85fa69ba38
1 fichiers modifiés avec 3 ajouts et 2 suppressions
  1. 3 2
      internal/ui/static/js/app.js

+ 3 - 2
internal/ui/static/js/app.js

@@ -540,10 +540,11 @@ function initializeMainMenuHandlers() {
 
 
     onClick(".header nav li", (event) => {
     onClick(".header nav li", (event) => {
         const linkElement = event.target.closest("a") || event.target.querySelector("a");
         const linkElement = event.target.closest("a") || event.target.querySelector("a");
-        if (linkElement) {
+        if (linkElement && !event.ctrlKey && !event.shiftKey && !event.metaKey) {
+            event.preventDefault();
             window.location.href = linkElement.getAttribute("href");
             window.location.href = linkElement.getAttribute("href");
         }
         }
-    });
+    }, true);
 }
 }
 
 
 /**
 /**