Browse Source

perf(rewrite): make getPredefinedRewriteRules O(1)

jvoisin 9 months ago
parent
commit
81df0b2a16
2 changed files with 4 additions and 6 deletions
  1. 3 5
      internal/reader/rewrite/rewriter.go
  2. 1 1
      internal/reader/rewrite/rules.go

+ 3 - 5
internal/reader/rewrite/rewriter.go

@@ -136,11 +136,9 @@ func parseRules(rulesText string) (rules []rule) {
 }
 }
 
 
 func getPredefinedRewriteRules(entryURL string) string {
 func getPredefinedRewriteRules(entryURL string) string {
-	urlDomain := urllib.Domain(entryURL)
-	for domain, rules := range predefinedRules {
-		if strings.Contains(urlDomain, domain) {
-			return rules
-		}
+	urlDomain := urllib.DomainWithoutWWW(entryURL)
+	if rules, ok := predefinedRules[urlDomain]; ok {
+		return rules
 	}
 	}
 
 
 	return ""
 	return ""

+ 1 - 1
internal/reader/rewrite/rules.go

@@ -26,11 +26,11 @@ var predefinedRules = map[string]string{
 	"optipess.com":           "add_image_title",
 	"optipess.com":           "add_image_title",
 	"peebleslab.com":         "add_image_title",
 	"peebleslab.com":         "add_image_title",
 	"quantamagazine.org":     `add_youtube_video_from_id, remove("h6:not(.byline,.post__title__kicker), #comments, .next-post__content, .footer__section, figure .outer--content, script")`,
 	"quantamagazine.org":     `add_youtube_video_from_id, remove("h6:not(.byline,.post__title__kicker), #comments, .next-post__content, .footer__section, figure .outer--content, script")`,
+	"qwantz.com":             "add_image_title,add_mailto_subject",
 	"sentfromthemoon.com":    "add_image_title",
 	"sentfromthemoon.com":    "add_image_title",
 	"thedoghousediaries.com": "add_image_title",
 	"thedoghousediaries.com": "add_image_title",
 	"theverge.com":           `add_dynamic_image, remove("div.duet--recirculation--related-list, .hidden")`,
 	"theverge.com":           `add_dynamic_image, remove("div.duet--recirculation--related-list, .hidden")`,
 	"treelobsters.com":       "add_image_title",
 	"treelobsters.com":       "add_image_title",
-	"www.qwantz.com":         "add_image_title,add_mailto_subject",
 	"xkcd.com":               "add_image_title",
 	"xkcd.com":               "add_image_title",
 	"youtube.com":            "add_youtube_video",
 	"youtube.com":            "add_youtube_video",
 }
 }