Просмотр исходного кода

refactor(rewrite): avoid string concatenation in a loop (perfsprint linter fix)

Julien Voisin 7 месяцев назад
Родитель
Сommit
093004b724
1 измененных файлов с 4 добавлено и 3 удалено
  1. 4 3
      internal/reader/rewrite/content_rewrite_functions.go

+ 4 - 3
internal/reader/rewrite/content_rewrite_functions.go

@@ -315,13 +315,14 @@ func addYoutubeVideoFromId(entryContent string) string {
 	if matches == nil {
 		return entryContent
 	}
-	videoPlayerHTML := ""
+	var videoPlayerHTML strings.Builder
 	for _, match := range matches {
 		if len(match) == 2 {
-			videoPlayerHTML += buildVideoPlayerIframe(config.Opts.YouTubeEmbedUrlOverride()+match[1]) + "<br>"
+			videoPlayerHTML.WriteString(buildVideoPlayerIframe(config.Opts.YouTubeEmbedUrlOverride() + match[1]))
+			videoPlayerHTML.WriteString("<br>")
 		}
 	}
-	return videoPlayerHTML + entryContent
+	return videoPlayerHTML.String() + entryContent
 }
 
 func addInvidiousVideo(entryURL, entryContent string) string {