Browse Source

Revert "Add support for scanning single branch"

Zachary Rice 7 years ago
parent
commit
98173b3aa6
3 changed files with 3 additions and 41 deletions
  1. 0 4
      github.go
  2. 0 17
      gitleaks_test.go
  3. 3 20
      main.go

+ 0 - 4
github.go

@@ -170,10 +170,6 @@ func auditGithubRepos() ([]Leak, error) {
 			continue
 		}
 		leaksFromRepo, err := auditGitRepo(repo)
-		if err != nil {
-			log.Warn(err)
-			continue
-		}
 		if opts.Disk {
 			os.RemoveAll(fmt.Sprintf("%s/%s", ownerDir, *githubRepo.Name))
 		}

+ 0 - 17
gitleaks_test.go

@@ -320,23 +320,6 @@ func TestRun(t *testing.T) {
 			expectedErrMsg: "",
 			commitPerPage:  1,
 		},
-		{
-			testOpts: Options{
-				Repo:   "https://github.com/gitleakstest/gronit.git",
-				Branch: "master",
-			},
-			description: "test github leaks on single branch - master",
-			numLeaks:    2,
-		},
-		{
-			testOpts: Options{
-				Repo:   "https://github.com/gitleakstest/gronit.git",
-				Branch: "nonExistingBranch",
-			},
-			description:    "test github leaks on single branch which doesn't exist",
-			numLeaks:       0,
-			expectedErrMsg: "reference not found",
-		},
 	}
 	g := goblin.Goblin(t)
 	for _, test := range tests {

+ 3 - 20
main.go

@@ -25,7 +25,6 @@ import (
 
 	diffType "gopkg.in/src-d/go-git.v4/plumbing/format/diff"
 	"gopkg.in/src-d/go-git.v4/plumbing/object"
-	"gopkg.in/src-d/go-git.v4/plumbing/storer"
 	"gopkg.in/src-d/go-git.v4/plumbing/transport/ssh"
 	"gopkg.in/src-d/go-git.v4/storage/memory"
 
@@ -71,9 +70,8 @@ type Options struct {
 	GitLabUser string `long:"gitlab-user" description:"GitLab user ID to audit"`
 	GitLabOrg  string `long:"gitlab-org" description:"GitLab group ID to audit"`
 
-	Commit string                 `short:"c" long:"commit" description:"sha of commit to stop at"`
-	Depth  int                    `long:"depth" description:"maximum commit depth"`
-	Branch plumbing.ReferenceName `long:"branch" description:"scan remote branch only (default is all)"`
+	Commit string `short:"c" long:"commit" description:"sha of commit to stop at"`
+	Depth  int    `long:"depth" description:"maximum commit depth"`
 
 	// local target option
 	RepoPath  string `long:"repo-path" description:"Path to repo"`
@@ -466,7 +464,6 @@ func auditGitRepo(repo *RepoDescriptor) ([]Leak, error) {
 	var (
 		err   error
 		leaks []Leak
-		refs  storer.ReferenceIter
 	)
 	for _, re := range whiteListRepos {
 		if re.FindString(repo.name) != "" {
@@ -485,21 +482,7 @@ func auditGitRepo(repo *RepoDescriptor) ([]Leak, error) {
 	// clear commit cache
 	commitMap = make(map[string]bool)
 
-	if opts.Branch != "" {
-		// var branchRef plumbing.ReferenceName
-		branchRef := "refs/remotes/origin/" + opts.Branch
-		log.Debugf("Auditing ref: %v", branchRef)
-		ref, err := repo.repository.Storer.Reference(branchRef)
-		if err != nil {
-			return leaks, err
-		}
-		branchLeaks := auditGitReference(repo, ref)
-		for _, leak := range branchLeaks {
-			leaks = append(leaks, leak)
-		}
-		return leaks, nil
-	}
-	refs, err = repo.repository.Storer.IterReferences()
+	refs, err := repo.repository.Storer.IterReferences()
 	if err != nil {
 		return leaks, err
 	}