浏览代码

Fix G307 warning: Deferring unsafe method "Close" on type "*os.File" (#1154)

* fix: check potential error from file.Close

* fix(detect): use existing logger
Richard Gomez 3 年之前
父节点
当前提交
81cf30855c
共有 1 个文件被更改,包括 6 次插入1 次删除
  1. 6 1
      detect/detect.go

+ 6 - 1
detect/detect.go

@@ -154,7 +154,12 @@ func (d *Detector) AddGitleaksIgnore(gitleaksIgnorePath string) error {
 		return err
 	}
 
-	defer file.Close()
+	// https://github.com/securego/gosec/issues/512
+	defer func() {
+		if err := file.Close(); err != nil { 
+			log.Warn().Msgf("Error closing .gitleaksignore file: %s\n", err)
+		}
+    }()
 	scanner := bufio.NewScanner(file)
 
 	for scanner.Scan() {