Просмотр исходного кода

coroparse: Fix newly introduced warning

Small fix for a problem introduced by "coroparse: Use key_name for error
message" patch.

Signed-off-by: Jan Friesse <jfriesse@redhat.com>
Jan Friesse 7 лет назад
Родитель
Сommit
e3989c2b56
1 измененных файлов с 6 добавлено и 3 удалено
  1. 6 3
      exec/coroparse.c

+ 6 - 3
exec/coroparse.c

@@ -1421,10 +1421,13 @@ atoi_error:
 	 */
 	assert(safe_atoq_range(val_type, &min_val, &max_val) == 0);
 
-	snprintf(formated_err, sizeof(formated_err),
+	if (snprintf(formated_err, sizeof(formated_err),
 	    "Value of key \"%s\" is expected to be integer in range (%lld..%lld), but \"%s\" was given",
-	    key_name, min_val, max_val, value);
-	*error_string = formated_err;
+	    key_name, min_val, max_val, value) >= sizeof(formated_err)) {
+		*error_string = "Can't format parser error message";
+	} else {
+		*error_string = formated_err;
+	}
 
 	return (0);