Просмотр исходного кода

Fix coverity bug ID 1: overused local variable

coverity says that in exec/objdb.c: 1075 the found is always == 1
therefore the code is dead.  But this is just a case of an overused
local variable. "found" is used for two different searches.



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1716 fd59a12c-fef9-0310-b244-a6a79926bd2f
Angus Salkeld 17 лет назад
Родитель
Сommit
aec3b38cde
1 измененных файлов с 3 добавлено и 2 удалено
  1. 3 2
      exec/objdb.c

+ 3 - 2
exec/objdb.c

@@ -1052,6 +1052,7 @@ static int object_key_replace (
 
 
 	if (found) {
 	if (found) {
 		int i;
 		int i;
+		int found_validator = 0;
 
 
 		/*
 		/*
 		 * Do validation check if validation is configured for the parent object
 		 * Do validation check if validation is configured for the parent object
@@ -1064,7 +1065,7 @@ static int object_key_replace (
 					     instance->object_key_valid_list[i].key_name,
 					     instance->object_key_valid_list[i].key_name,
 					     key_len) == 0)) {
 					     key_len) == 0)) {
 
 
-					found = 1;
+					found_validator = 1;
 					break;
 					break;
 				}
 				}
 			}
 			}
@@ -1072,7 +1073,7 @@ static int object_key_replace (
 			/*
 			/*
 			 * Item not found in validation list
 			 * Item not found in validation list
 			 */
 			 */
-			if (found == 0) {
+			if (found_validator == 0) {
 				goto error_put;
 				goto error_put;
 			} else {
 			} else {
 				if (instance->object_key_valid_list[i].validate_callback) {
 				if (instance->object_key_valid_list[i].validate_callback) {