Bläddra i källkod

totemknet: Ignore icmap_get_string result

... and add comment why it is not a bug.

Signed-off-by: Jan Friesse <jfriesse@redhat.com>
Reviewed-by: Christine Caulfield <ccaulfie@redhat.com>
Jan Friesse 6 år sedan
förälder
incheckning
9b809383e6
1 ändrade filer med 6 tillägg och 2 borttagningar
  1. 6 2
      exec/totemknet.c

+ 6 - 2
exec/totemknet.c

@@ -1795,8 +1795,12 @@ static int setup_nozzle(void *knet_context)
 	int macaddr_res;
 	int macaddr_res;
 	int res;
 	int res;
 
 
-	icmap_get_string(NOZZLE_IPADDR, &ipaddr_str);
-	icmap_get_string(NOZZLE_PREFIX, &prefix_str);
+	/*
+	 * Return value ignored on purpose. icmap_get_string changes
+	 * ipaddr_str/prefix_str only on success.
+	 */
+	(void)icmap_get_string(NOZZLE_IPADDR, &ipaddr_str);
+	(void)icmap_get_string(NOZZLE_PREFIX, &prefix_str);
 	macaddr_res = icmap_get_string(NOZZLE_MACADDR, &macaddr_str);
 	macaddr_res = icmap_get_string(NOZZLE_MACADDR, &macaddr_str);
 	name_res = icmap_get_string(NOZZLE_NAME, &name_str);
 	name_res = icmap_get_string(NOZZLE_NAME, &name_str);