Fix coverity bug ID 9: OVERRUN_STATIC

CID: 9
Checker: OVERRUN_STATIC (help)
File: lib/cfg.c
Function: corosync_cfg_service_unload
Description: Overrun of static array
"&(req_lib_cfg_serviceunload).service_name" of size 1024 bytes by
passing it to a function which indexes it with argument "1023" at byte
position 4088

The main problem here is the way the service_name is defined:
-       char *service_name[256] __attribute__((aligned(8)));
+       char service_name[256] __attribute__((aligned(8)));



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1718 fd59a12c-fef9-0310-b244-a6a79926bd2f

include/corosync/ipc_cfg.h

@@ -128,7 +128,7 @@ struct res_lib_cfg_ringreenable {
 
 struct req_lib_cfg_serviceload {
 	mar_res_header_t header __attribute__((aligned(8)));
-	char *service_name[256] __attribute__((aligned(8)));
+	char service_name[256] __attribute__((aligned(8)));
 	unsigned int service_ver;
 };
 
@@ -138,7 +138,7 @@ struct res_lib_cfg_serviceload {
 
 struct req_lib_cfg_serviceunload {
 	mar_res_header_t header __attribute__((aligned(8)));
-	char *service_name[256] __attribute__((aligned(8)));
+	char service_name[256] __attribute__((aligned(8)));
 	unsigned int service_ver;
 };
 

lib/cfg.c

@@ -483,7 +483,7 @@ corosync_cfg_service_load (
 	req_lib_cfg_serviceload.header.id = MESSAGE_REQ_CFG_SERVICELOAD;
 	memset (&req_lib_cfg_serviceload.service_name, 0,
 		sizeof (req_lib_cfg_serviceload.service_name));
-	strncpy ((char *)req_lib_cfg_serviceload.service_name, service_name,
+	strncpy (req_lib_cfg_serviceload.service_name, service_name,
 		sizeof (req_lib_cfg_serviceload.service_name) - 1);
 	req_lib_cfg_serviceload.service_ver = service_ver;
 
@@ -521,7 +521,7 @@ corosync_cfg_service_unload (
 	req_lib_cfg_serviceunload.header.id = MESSAGE_REQ_CFG_SERVICEUNLOAD;
 	memset (&req_lib_cfg_serviceunload.service_name, 0,
 		sizeof (req_lib_cfg_serviceunload.service_name));
-	strncpy ((char *)req_lib_cfg_serviceunload.service_name, service_name,
+	strncpy (req_lib_cfg_serviceunload.service_name, service_name,
 		sizeof (req_lib_cfg_serviceunload.service_name) - 1);
 	req_lib_cfg_serviceunload.service_ver = service_ver;