Преглед изворни кода

totemknet: Initialize return value in setup_nozzle

Also add comment why return value is currently not used.

Signed-off-by: Jan Friesse <jfriesse@redhat.com>
Reviewed-by: Christine Caulfield <ccaulfie@redhat.com>
Jan Friesse пре 6 година
родитељ
комит
0839d3af82
1 измењених фајлова са 5 додато и 3 уклоњено
  1. 5 3
      exec/totemknet.c

+ 5 - 3
exec/totemknet.c

@@ -1428,8 +1428,10 @@ int totemknet_reconfigure (
 	}
 
 #ifdef HAVE_LIBNOZZLE
-	/* Set up nozzle device(s) */
-	setup_nozzle(instance);
+	/* Set up nozzle device(s). Return code is ignored, because unability
+	 * configure nozzle is not fatal problem, errors are logged and
+	 * there is not much else we can do */
+	(void)setup_nozzle(instance);
 #endif
 	return (res);
 }
@@ -1793,7 +1795,7 @@ static int setup_nozzle(void *knet_context)
 	char mac[32];
 	int name_res;
 	int macaddr_res;
-	int res;
+	int res = -1;
 
 	/*
 	 * Return value ignored on purpose. icmap_get_string changes