瀏覽代碼

qdevice: Suppress Coverity errors

Weak crypto is fine, because random is not used in security context and
forward null one is false positive.

Signed-off-by: Jan Friesse <jfriesse@redhat.com>
Jan Friesse 3 月之前
父節點
當前提交
3aeee71d67
共有 2 個文件被更改,包括 2 次插入0 次删除
  1. 1 0
      qdevices/qdevice-model-net.c
  2. 1 0
      qdevices/qnetd-cluster-list.c

+ 1 - 0
qdevices/qdevice-model-net.c

@@ -374,6 +374,7 @@ qdevice_model_net_post_poll_loop(struct qdevice_instance *instance,
 		 * Coverity reports weak_crypto error on following line, what's not a problem
 		 * because cryptographically secure pseudorandom number generator is not needed.
 		 */
+		// coverity[DC.WEAK_CRYPTO:SUPPRESS] random is not used in a security context
 		delay_before_reconnect = random() %
 		    (int)(net_instance->cast_vote_timer_interval * 0.9);
 

+ 1 - 0
qdevices/qnetd-cluster-list.c

@@ -114,6 +114,7 @@ qnetd_cluster_list_add_client(struct qnetd_cluster_list *list, struct qnetd_clie
 		/*
 		 * Coverity reports false positive var_deref_op error on following line
 		 */
+		// coverity[FORWARD_NULL:SUPPRESS] false positive
 		TAILQ_INSERT_TAIL(&cluster->client_list, client, cluster_entries);
 	}