RenameResourceTests.cs 12 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317
  1. using Tests.EndToEnd.Infra;
  2. using Xunit.Abstractions;
  3. namespace Tests.EndToEnd.ConnectionTests;
  4. [Collection("Process-wide static state")]
  5. public class RenameResourceTests(TempYamlCliFixture fs, ITestOutputHelper outputHelper)
  6. : IClassFixture<TempYamlCliFixture> {
  7. private async Task<(string output, string yaml)> ExecuteAsync(params string[] args) {
  8. outputHelper.WriteLine($"rpk {string.Join(" ", args)}");
  9. var output = await YamlCliTestHost.RunAsync(
  10. args,
  11. fs.Root,
  12. outputHelper,
  13. "config.yaml");
  14. outputHelper.WriteLine(output);
  15. var yaml = await File.ReadAllTextAsync(Path.Combine(fs.Root, "config.yaml"));
  16. return (output, yaml);
  17. }
  18. [Fact]
  19. public async Task rename_server_with_single_connection_preserves_connection() {
  20. await ExecuteAsync("servers", "add", "srv01");
  21. await ExecuteAsync("servers", "add", "srv02");
  22. await ExecuteAsync("servers", "nic", "add", "srv01",
  23. "--type", "RJ45", "--speed", "10", "--ports", "2");
  24. await ExecuteAsync("servers", "nic", "add", "srv02",
  25. "--type", "RJ45", "--speed", "10", "--ports", "2");
  26. await ExecuteAsync("connections", "add",
  27. "srv01", "0", "0",
  28. "srv02", "0", "0",
  29. "--label", "uplink-test");
  30. await ExecuteAsync("servers", "rename", "srv01", "srv01-renamed");
  31. (_, var yaml) = await ExecuteAsync("servers", "get", "srv01-renamed");
  32. Assert.Contains("name: srv01-renamed", yaml);
  33. Assert.Contains("srv01-renamed", yaml);
  34. Assert.Contains("srv02", yaml);
  35. Assert.Contains("uplink-test", yaml);
  36. }
  37. [Fact]
  38. public async Task rename_server_with_multiple_connections_preserves_all() {
  39. await ExecuteAsync("servers", "add", "srv01");
  40. await ExecuteAsync("servers", "add", "srv02");
  41. await ExecuteAsync("servers", "add", "srv03");
  42. await ExecuteAsync("servers", "add", "srv04");
  43. foreach (var s in new[] { "srv01", "srv02", "srv03", "srv04" }) {
  44. await ExecuteAsync("servers", "nic", "add", s,
  45. "--type", "RJ45", "--speed", "10", "--ports", "2");
  46. }
  47. await ExecuteAsync("connections", "add",
  48. "srv01", "0", "0",
  49. "srv02", "0", "0",
  50. "--label", "conn-to-srv02");
  51. await ExecuteAsync("connections", "add",
  52. "srv01", "0", "1",
  53. "srv03", "0", "0",
  54. "--label", "conn-to-srv03");
  55. await ExecuteAsync("connections", "add",
  56. "srv02", "0", "1", // changed
  57. "srv04", "0", "1",
  58. "--label", "conn-to-srv04");
  59. await ExecuteAsync("servers", "rename", "srv01", "srv01-updated");
  60. var yaml = await File.ReadAllTextAsync(Path.Combine(fs.Root, "config.yaml"));
  61. Assert.Contains("name: srv01-updated", yaml);
  62. Assert.Contains("srv01-updated", yaml);
  63. Assert.Contains("srv02", yaml);
  64. Assert.Contains("srv03", yaml);
  65. Assert.Contains("srv04", yaml);
  66. Assert.Contains("conn-to-srv02", yaml);
  67. Assert.Contains("conn-to-srv03", yaml);
  68. Assert.Contains("conn-to-srv04", yaml);
  69. }
  70. [Fact]
  71. public async Task rename_both_connection_endpoints_preserves_connection() {
  72. await ExecuteAsync("servers", "add", "srv01");
  73. await ExecuteAsync("servers", "add", "srv02");
  74. await ExecuteAsync("servers", "nic", "add", "srv01",
  75. "--type", "RJ45", "--speed", "10", "--ports", "2");
  76. await ExecuteAsync("servers", "nic", "add", "srv02",
  77. "--type", "RJ45", "--speed", "10", "--ports", "2");
  78. await ExecuteAsync("connections", "add",
  79. "srv01", "0", "0",
  80. "srv02", "0", "0",
  81. "--label", "bi-directional-link");
  82. await ExecuteAsync("servers", "rename", "srv01", "new-srv01");
  83. await ExecuteAsync("servers", "rename", "srv02", "new-srv02");
  84. (_, var yaml) = await ExecuteAsync("servers", "get", "new-srv01");
  85. Assert.Contains("name: new-srv01", yaml);
  86. Assert.Contains("new-srv01", yaml);
  87. Assert.Contains("new-srv02", yaml);
  88. Assert.Contains("bi-directional-link", yaml);
  89. }
  90. [Fact]
  91. public async Task rename_switch_with_connections_preserves_connections() {
  92. await ExecuteAsync("switches", "add", "sw01");
  93. await ExecuteAsync("switches", "add", "sw02");
  94. await ExecuteAsync("switches", "port", "add", "sw01",
  95. "--type", "SFP+", "--speed", "25", "--count", "2");
  96. await ExecuteAsync("switches", "port", "add", "sw02",
  97. "--type", "SFP+", "--speed", "25", "--count", "2");
  98. await ExecuteAsync("connections", "add",
  99. "sw01", "0", "0",
  100. "sw02", "0", "0",
  101. "--label", "switch-uplink");
  102. await ExecuteAsync("switches", "rename", "sw01", "sw01-core");
  103. (_, var yaml) = await ExecuteAsync("switches", "get", "sw01-core");
  104. Assert.Contains("name: sw01-core", yaml);
  105. Assert.Contains("sw01-core", yaml);
  106. Assert.Contains("sw02", yaml);
  107. Assert.Contains("switch-uplink", yaml);
  108. }
  109. [Fact]
  110. public async Task rename_typed_in_different_case_preserves_connection() {
  111. await ExecuteAsync("servers", "add", "Case01");
  112. await ExecuteAsync("servers", "add", "Case02");
  113. await ExecuteAsync("servers", "nic", "add", "Case01",
  114. "--type", "RJ45", "--speed", "10", "--ports", "2");
  115. await ExecuteAsync("servers", "nic", "add", "Case02",
  116. "--type", "RJ45", "--speed", "10", "--ports", "2");
  117. await ExecuteAsync("connections", "add",
  118. "Case01", "0", "0",
  119. "Case02", "0", "0",
  120. "--label", "mixed-case-link");
  121. await ExecuteAsync("servers", "rename", "case01", "Case01-renamed");
  122. (_, var yaml) = await ExecuteAsync("servers", "get", "Case01-renamed");
  123. Assert.Contains("name: Case01-renamed", yaml);
  124. Assert.Contains("mixed-case-link", yaml);
  125. // The connection endpoint should follow the rename, not keep pointing at the old name
  126. Assert.Contains("resource: Case01-renamed", yaml);
  127. }
  128. [Fact]
  129. public async Task rename_typed_in_different_case_updates_runs_on() {
  130. await ExecuteAsync("servers", "add", "Case11");
  131. await ExecuteAsync("systems", "add", "sys-case-11");
  132. await ExecuteAsync("systems", "set", "sys-case-11", "--runs-on", "Case11");
  133. await ExecuteAsync("servers", "rename", "case11", "Case12");
  134. (_, var yaml) = await ExecuteAsync("servers", "get", "Case12");
  135. Assert.Contains("name: Case12", yaml);
  136. // The dependant system should follow the rename
  137. Assert.Contains("- Case12", yaml);
  138. }
  139. [Fact]
  140. public async Task rename_with_special_naming_preserves_connections() {
  141. await ExecuteAsync("servers", "add", "srv-prod-web-01");
  142. await ExecuteAsync("servers", "add", "srv-prod-app-01");
  143. await ExecuteAsync("servers", "nic", "add", "srv-prod-web-01",
  144. "--type", "RJ45", "--speed", "10", "--ports", "2");
  145. await ExecuteAsync("servers", "nic", "add", "srv-prod-app-01",
  146. "--type", "RJ45", "--speed", "10", "--ports", "2");
  147. await ExecuteAsync("connections", "add",
  148. "srv-prod-web-01", "0", "0",
  149. "srv-prod-app-01", "0", "0",
  150. "--label", "app-backend-link");
  151. await ExecuteAsync("servers", "rename", "srv-prod-web-01", "srv_prod_web_01");
  152. (_, var yaml) = await ExecuteAsync("servers", "get", "srv_prod_web_01");
  153. Assert.Contains("name: srv_prod_web_01", yaml);
  154. Assert.Contains("srv_prod_web_01", yaml);
  155. Assert.Contains("srv-prod-app-01", yaml);
  156. Assert.Contains("app-backend-link", yaml);
  157. }
  158. [Fact]
  159. public async Task rename_that_only_changes_case_updates_the_name() {
  160. await ExecuteAsync("servers", "add", "CaseOnly21");
  161. (var output, var yaml) = await ExecuteAsync("servers", "rename", "CaseOnly21", "caseonly21");
  162. Assert.Contains("Server 'CaseOnly21' renamed to 'caseonly21'.", output);
  163. Assert.Contains("name: caseonly21", yaml);
  164. Assert.DoesNotContain("name: CaseOnly21", yaml);
  165. }
  166. [Fact]
  167. public async Task rename_that_only_changes_case_updates_runs_on_and_connections() {
  168. await ExecuteAsync("servers", "add", "CaseOnly31");
  169. await ExecuteAsync("servers", "add", "CaseOnly32");
  170. await ExecuteAsync("servers", "nic", "add", "CaseOnly31",
  171. "--type", "RJ45", "--speed", "10", "--ports", "2");
  172. await ExecuteAsync("servers", "nic", "add", "CaseOnly32",
  173. "--type", "RJ45", "--speed", "10", "--ports", "2");
  174. await ExecuteAsync("connections", "add",
  175. "CaseOnly31", "0", "0",
  176. "CaseOnly32", "0", "0",
  177. "--label", "case-only-link");
  178. await ExecuteAsync("systems", "add", "sys-case-only-31");
  179. await ExecuteAsync("systems", "set", "sys-case-only-31", "--runs-on", "CaseOnly31");
  180. (var output, var yaml) = await ExecuteAsync("servers", "rename", "CaseOnly31", "CASEONLY31");
  181. Assert.Contains("Server 'CaseOnly31' renamed to 'CASEONLY31'.", output);
  182. Assert.Contains("name: CASEONLY31", yaml);
  183. Assert.Contains("resource: CASEONLY31", yaml);
  184. Assert.Contains("- CASEONLY31", yaml);
  185. Assert.DoesNotContain("CaseOnly31", yaml);
  186. }
  187. [Fact]
  188. public async Task rename_onto_another_resources_case_variant_is_still_refused() {
  189. await ExecuteAsync("servers", "add", "Clash41");
  190. await ExecuteAsync("servers", "add", "Clash42");
  191. await ExecuteAsync("systems", "add", "clash43");
  192. (var sameKind, _) = await ExecuteAsync("servers", "rename", "Clash41", "CLASH42");
  193. (var otherKind, var yaml) = await ExecuteAsync("servers", "rename", "Clash41", "CLASH43");
  194. Assert.Contains("Conflict: Server resource 'CLASH42' already exists.", sameKind);
  195. Assert.Contains("Conflict: System resource 'CLASH43' already exists.", otherKind);
  196. Assert.Contains("name: Clash41", yaml);
  197. Assert.Contains("name: Clash42", yaml);
  198. Assert.Contains("name: clash43", yaml);
  199. Assert.DoesNotContain("CLASH4", yaml);
  200. }
  201. [Fact]
  202. public async Task rename_to_the_identical_name_leaves_the_file_unchanged() {
  203. await ExecuteAsync("servers", "add", "Same51");
  204. await ExecuteAsync("servers", "add", "Same52");
  205. await ExecuteAsync("servers", "add", "Same53");
  206. foreach (var s in new[] { "Same51", "Same52", "Same53" }) {
  207. await ExecuteAsync("servers", "nic", "add", s,
  208. "--type", "RJ45", "--speed", "10", "--ports", "2");
  209. }
  210. await ExecuteAsync("connections", "add",
  211. "Same51", "0", "0",
  212. "Same52", "0", "0",
  213. "--label", "same-link");
  214. await ExecuteAsync("connections", "add",
  215. "Same52", "0", "1",
  216. "Same53", "0", "0",
  217. "--label", "other-link");
  218. await ExecuteAsync("systems", "add", "sys-same-51");
  219. (_, var before) = await ExecuteAsync("systems", "set", "sys-same-51", "--runs-on", "same51");
  220. (var output, var after) = await ExecuteAsync("servers", "rename", "Same51", "Same51");
  221. Assert.Contains("Server 'Same51' renamed to 'Same51'.", output);
  222. Assert.Equal(before, after);
  223. }
  224. [Fact]
  225. public async Task rename_is_refused_when_the_config_already_holds_a_case_variant() {
  226. await File.WriteAllTextAsync(Path.Combine(fs.Root, "config.yaml"), """
  227. version: 4
  228. resources:
  229. - kind: Server
  230. name: Dup61
  231. - kind: Server
  232. name: dup61
  233. connections: []
  234. """);
  235. (var output, var yaml) = await ExecuteAsync("servers", "rename", "Dup61", "DUP61");
  236. Assert.Contains("Conflict: Server resource 'DUP61' already exists.", output);
  237. Assert.Contains("name: Dup61", yaml);
  238. Assert.Contains("name: dup61", yaml);
  239. Assert.DoesNotContain("DUP61", yaml);
  240. }
  241. }