Fix edit tab name if exists

api/pages/settings-tab-editor-tabs.php

@@ -103,6 +103,7 @@ allIcons().success(function(data) {
 </form>
 <form id="edit-tab-form" class="mfp-hide white-popup-block mfp-with-anim">
     <input type="hidden" name="id" value="x">
+    <span class="hidden" id="originalTabName"></span>
     <h1 lang="en">Edit Tab</h1>
     <fieldset style="border:0;">
     	<div class="alert alert-success alert-dismissable tabEditTestMessage hidden">

js/custom.js

@@ -846,6 +846,7 @@ $(document).on("click", ".deleteTab", function () {
 //EDIT TAB GET ID
 $(document).on("click", ".editTabButton", function () {
     $('#edit-tab-form [name=tabName]').val($(this).parent().parent().attr("data-name"));
+    $('#originalTabName').html($(this).parent().parent().attr("data-name"));
     $('#edit-tab-form [name=tabURL]').val($(this).parent().parent().attr("data-url"));
     $('#edit-tab-form [name=tabLocalURL]').val($(this).parent().parent().attr("data-local-url"));
     $('#edit-tab-form [name=pingURL]').val($(this).parent().parent().attr("data-ping-url"));
@@ -859,6 +860,7 @@ $(document).on("click", ".editTabButton", function () {
 });
 //EDIT TAB
 $(document).on("click", ".editTab", function () {
+    var originalTabName = $('#originalTabName').html();
     //Create POST Array
     var post = {
         action:'editTab',
@@ -885,8 +887,8 @@ $(document).on("click", ".editTab", function () {
     if ((typeof post.tabURL == 'undefined' || post.tabURL == '') && (typeof post.tabLocalURL == 'undefined' || post.tabLocalURL == '')) {
         message('Edit Tab Error',' Please set a Tab URL or Local URL',activeInfo.settings.notifications.position,'#FFF','warning','5000');
     }
-    if(checkIfTabNameExists(post.tabName)){
-        message('New Tab Error',' Tab name already used',activeInfo.settings.notifications.position,'#FFF','warning','5000');
+    if(checkIfTabNameExists(post.tabName) && originalTabName !== post.tabName){
+        message('Edit Tab Error',' Tab name already used',activeInfo.settings.notifications.position,'#FFF','warning','5000');
         return false;
     }
     if(post.id !== '' && post.tabName !== '' && post.tabImage !== ''){

js/functions.js

@@ -6308,7 +6308,6 @@ function getAllTabNames(){
     var allTabs = $('.allTabsList');
     var tabList = [];
     $.each(allTabs, function(i,v) {
-        console.log(v.getAttribute('data-tab-name'));
         tabList[i] = v.getAttribute('data-tab-name').toLowerCase();
     });
     return tabList;