瀏覽代碼

doc: CONTRIBUTING - add more guidelines

jamesread 1 年之前
父節點
當前提交
7ddc112b2c
共有 1 個文件被更改,包括 8 次插入0 次删除
  1. 8 0
      CONTRIBUTING.adoc

+ 8 - 0
CONTRIBUTING.adoc

@@ -11,6 +11,14 @@ Ideas may be discussed, purely on their merits and issues. Our Code of Conduct
 discussion throughout the whole process. This project respects the
 discussion throughout the whole process. This project respects the
 link:https://www.kernel.org/doc/html/latest/process/code-of-conduct.html[Linux Kernel code of conduct].
 link:https://www.kernel.org/doc/html/latest/process/code-of-conduct.html[Linux Kernel code of conduct].
 
 
+== More than 3 lines - talk to someone first
+
+If you're planning on making a change that's more than a 3 lines, please talk to someone first. This is so that you don't waste your time on something that might not be accepted. It's also a good way to get some feedback on your idea and make sure you're on the right track.
+
+== A PR should be one logical change
+
+Please try to keep your pull requests small and focused. It's almost impossible to review PRs that change lots of files for lots of different reasons. If you have a big change, it's probably best to break it down into smaller, more manageable chunks, otherwise it's likely to be rejected.
+
 == If you're not sure, ask!
 == If you're not sure, ask!
 
 
 Don't be afraid to ask for advice before working on a
 Don't be afraid to ask for advice before working on a