Merge branch 'hotfix/v23.3.4'

.github/workflows/add-to-project.yml

@@ -1,4 +1,4 @@
-name: Add to project
+name: Add to Project
 on:
   issues:
     types:
@@ -7,10 +7,10 @@ on:
 
 jobs:
   add-to-project:
-    name: Add game server requests to project
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/add-to-project@v0.5.0
+      - name: Add to Project
+        uses: actions/add-to-project@v0.5.0
         with:
           project-url: https://github.com/orgs/GameServerManagers/projects/11
           github-token: ${{ secrets.ADD_TO_PROJECT_PAT }}

.github/workflows/details-check.yml

@@ -1,5 +1,5 @@
-name: Details Check
 # This action will check that LinuxGSM is picking up game server config and parameter variables.
+name: Details Check
 on:
   workflow_dispatch:
   push:
@@ -20,7 +20,8 @@ jobs:
       - name: Generate matrix with generate-matrix.sh
         run: chmod +x .github/workflows/detals-check-generate-matrix.sh; .github/workflows/detals-check-generate-matrix.sh
 
-      - id: set-matrix
+      - name: Set Matrix
+        id: set-matrix
         run: |
           shortnamearray=$(cat shortnamearray.json)
           echo "${shortnamearray}"
@@ -47,8 +48,8 @@ jobs:
       - name: Enable developer mode
         run: LGSM_GITHUBBRANCH="${GITHUB_REF#refs/heads/}" ./${{ matrix.shortname }}server developer
 
-      - id: sets-servercfgname
-        name: Generate servercfgname
+      - name: Generate servercfgname
+        id: sets-servercfgname
         run: |
           servercfg=$(sed -n "/^\<servercfgdefault\>/ { s/.*= *\"\?\([^\"']*\)\"\?/\1/p;q }" lgsm/config-lgsm/${{ matrix.shortname }}server/_default.cfg)
           echo "servercfgname=$servercfg" >> "$GITHUB_OUTPUT"
@@ -58,7 +59,7 @@ jobs:
           if [ -z "${{ steps.sets-servercfgname.outputs.servercfgname }}" ]; then
             echo "This game server has no config file."
           else
-            curl -f -o config "https://raw.githubusercontent.com/GameServerManagers/Game-Server-Configs/rename/${{ matrix.shortname }}/${{ steps.sets-servercfgname.outputs.servercfgname }}"
+            curl -f -o config "https://raw.githubusercontent.com/GameServerManagers/Game-Server-Configs/main/${{ matrix.shortname }}/${{ steps.sets-servercfgname.outputs.servercfgname }}"
           fi
       - name: Display config
         run: |

.github/workflows/git-sync.yml

@@ -1,4 +1,4 @@
-name: Github to Bitbucket sync
+name: Github to Bitbucket Sync
 # This action will sync the github repo with a backup bitbucket repo.
 # This will allow LinuxGSM to use Bitbucket as and alternative download if github fails.
 on:
@@ -6,16 +6,17 @@ on:
     branches:
       - master
       - develop
+
 jobs:
-  GitHub-to-Bitbucket:
+  gitHub-to-bitbucket:
     runs-on: ubuntu-latest
     steps:
-      - name: webfactory/ssh-agent@v0.8.0
+      - name: SSH Agent
         uses: webfactory/ssh-agent@v0.8.0
         with:
           ssh-private-key: ${{ secrets.BITBUCKET_SECRET }}
 
-      - name: wei/git-sync@v3.0.0
+      - name: Git Sync
         uses: wei/git-sync@v3.0.0
         with:
           ssh_private_key: ${{ secrets.BITBUCKET_SECRET }}

.github/workflows/label-sponsors.yml

@@ -1,14 +0,0 @@
-name: Label sponsors
-on:
-  pull_request:
-    types: [opened]
-  issues:
-    types: [opened]
-jobs:
-  build:
-    name: is-sponsor-label
-    runs-on: ubuntu-latest
-    steps:
-      - uses: JasonEtco/is-sponsor-label-action@v2
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/labeler.yml

@@ -1,24 +1,30 @@
-name: "Issue Labeler"
+name: Issue Labeler
 on:
   issues:
-    types: [opened, edited]
-  pull_request:
-    types: [opened, edited]
+    types:
+      - opened
+      - edited
 
 permissions:
+  issues: write
   contents: read
 
 jobs:
-  triage:
-    permissions:
-      contents: read # for github/issue-labeler to get repo contents
-      issues: write # for github/issue-labeler to create or remove labels
+  issue-labeler:
     runs-on: ubuntu-latest
     steps:
-      - uses: github/issue-labeler@v3.1
+      - name: Issue Labeler
+        uses: github/issue-labeler@v3.1
         with:
           repo-token: "${{ secrets.GITHUB_TOKEN }}"
           configuration-path: .github/labeler.yml
-          not-before:
           enable-versioned-regex: 0
           include-title: 1
+
+  is-sponsor-label:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Is Sponsor Label
+        uses: JasonEtco/is-sponsor-label-action@v2
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/lock.yml

@@ -1,20 +1,18 @@
-name: "Lock Threads"
-
+name: Lock Threads
 on:
   schedule:
-    - cron: "0 0 * * *"
+    - cron: "0 0 * * 1"
 
 permissions:
-  contents: read
+  issues: write
+  pull-requests: write
 
 jobs:
   lock:
-    permissions:
-      issues: write # for dessant/lock-threads to lock issues
-      pull-requests: write # for dessant/lock-threads to lock PRs
     runs-on: ubuntu-latest
     steps:
-      - uses: dessant/lock-threads@v4
+      - name: Lock Threads
+        uses: dessant/lock-threads@v4
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           issue-comment: >

.github/workflows/potential-duplicates.yml

@@ -1,30 +1,21 @@
 name: Potential Duplicates
 on:
   issues:
-    types: [opened]
+    types:
+      - opened
 jobs:
-  run:
+  potential-duplicates:
     runs-on: ubuntu-latest
     steps:
-      - uses: wow-actions/potential-duplicates@v1
+      - name: Potential Duplicates
+        uses: wow-actions/potential-duplicates@v1
         with:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          # Issue title filter work with anymatch https://www.npmjs.com/package/anymatch.
-          # Any matched issue will stop detection immediately.
-          # You can specify multi filters in each line.
           filter: ""
-          # Exclude keywords in title before detecting.
           exclude: ""
-          # Label to set, when potential duplicates are detected.
           label: potential-duplicate
-          # Get issues with state to compare. Supported state: 'all', 'closed', 'open'.
           state: all
-          # If similarity is higher than this threshold([0,1]), issue will be marked as duplicate.
           threshold: 0.8
-          # Reactions to be add to comment when potential duplicates are detected.
-          # Available reactions: "-1", "+1", "confused", "laugh", "heart", "hooray", "rocket", "eyes"
-          #reactions: 'eyes, confused'
-          # Comment to post when potential duplicates are detected.
           comment: >
             Potential duplicates: {{#issues}}
               - [#{{ number }}] {{ title }} ({{ accuracy }}%)

.github/workflows/serverlist-validate.yml

@@ -1,4 +1,4 @@
-name: Server list Validation
+name: Server List Validation
 on:
   workflow_dispatch:
   push:
@@ -7,7 +7,8 @@ jobs:
   serverlist-validate:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - name: Checkout
+        uses: actions/checkout@v3
 
-      - name: compare versions
+      - name: Compare Versions
         run: chmod +x .github/workflows/serverlist-validate.sh; .github/workflows/serverlist-validate.sh

.github/workflows/trigger-docker-build.yml

@@ -3,12 +3,13 @@ on:
   release:
     types:
       - published
+
 jobs:
   trigger_build_docker-linuxgsm:
-    name: Trigger Build docker-linuxgsm
     runs-on: ubuntu-latest
     steps:
-      - uses: convictional/trigger-workflow-and-wait@v1.6.5
+      - name: Trigger Workflow and Wait (linuxgsm)
+        uses: convictional/trigger-workflow-and-wait@v1.6.5
         with:
           owner: GameServerManagers
           repo: docker-linuxgsm
@@ -16,10 +17,10 @@ jobs:
           workflow_file_name: docker-publish.yml
 
   trigger_build_docker-gameserver:
-    name: Trigger Build docker-linuxgsm
     runs-on: ubuntu-latest
     steps:
-      - uses: convictional/trigger-workflow-and-wait@v1.6.5
+      - name: Trigger Workflow and Wait (gameserver)
+        uses: convictional/trigger-workflow-and-wait@v1.6.5
         with:
           owner: GameServerManagers
           repo: docker-gameserver

.github/workflows/update-copyright-years-in-license-file.yml

@@ -1,6 +1,4 @@
----
 name: Update copyright year(s) in license file
-
 on:
   workflow_dispatch:
   schedule:
@@ -10,10 +8,12 @@ jobs:
   update-license-year:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - name: Checkout
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0
-      - uses: FantasticFiasco/action-update-license-year@v3
+      - name: Action Update License Year
+        uses: FantasticFiasco/action-update-license-year@v3
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
           path: LICENSE.md

.github/workflows/version-check.yml

@@ -1,6 +1,6 @@
 name: Version Check
-
-on: push
+on:
+  push:
 
 permissions:
   contents: read
@@ -9,7 +9,8 @@ jobs:
   version-Check:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - name: Checkout
+        uses: actions/checkout@v3
 
-      - name: compare versions
+      - name: Version Check
         run: chmod +x .github/workflows/version-check.sh; .github/workflows/version-check.sh

lgsm/modules/check_executable.sh

@@ -7,6 +7,13 @@
 
 moduleselfname="$(basename "$(readlink -f "${BASH_SOURCE[0]}")")"
 
+# #4241 temporary fix for Satisfactory for upgrade betweern Update 7 & Update 8 - remove this once update 8 is released
+if [ "${shortname}" == "sf" ]; then
+	if [ ! -f "${serverfiles}/Engine/Binaries/Linux/UE4Server-Linux-Shipping" ]; then
+		ln -s "${serverfiles}/Engine/Binaries/Linux/UnrealServer-Linux-Shipping" "${serverfiles}/Engine/Binaries/Linux/UE4Server-Linux-Shipping"
+	fi
+fi
+
 # Check if executable exists
 execname=$(basename "${executable}")
 if [ ! -f "${executabledir}/${execname}" ]; then

lgsm/modules/core_functions.sh

@@ -8,7 +8,7 @@
 
 module_selfname="$(basename "$(readlink -f "${BASH_SOURCE[0]}")")"
 
-modulesversion="v23.3.3"
+modulesversion="v23.3.4"
 
 # Core
 

lgsm/modules/core_modules.sh

@@ -8,7 +8,7 @@
 
 moduleselfname="$(basename "$(readlink -f "${BASH_SOURCE[0]}")")"
 
-modulesversion="v23.3.3"
+modulesversion="v23.3.4"
 
 # Core
 

lgsm/modules/info_game.sh

@@ -131,7 +131,7 @@ fn_info_game_xml() {
 	else
 		servercfgparse="${servercfgfullpath}"
 	fi
-	eval "${1}"="$(xmllint --xpath "string(${2})" "${servercfgparse}")"
+	eval "${1}=\"$(xmllint --xpath "string(${2})" "${servercfgparse}")\""
 	configtype="xml"
 }
 

linuxgsm.sh

@@ -20,7 +20,7 @@ if [ -f ".dev-debug" ]; then
 	set -x
 fi
 
-version="v23.3.3"
+version="v23.3.4"
 shortname="core"
 gameservername="core"
 commandname="CORE"

tests/tests_fctrserver.sh

@@ -20,7 +20,7 @@ if [ -f ".dev-debug" ]; then
 	set -x
 fi
 
-version="v23.3.3"
+version="v23.3.4"
 shortname="fctr"
 gameservername="fctrserver"
 commandname="CORE"

tests/tests_jc2server.sh

@@ -20,7 +20,7 @@ if [ -f ".dev-debug" ]; then
 	set -x
 fi
 
-version="v23.3.3"
+version="v23.3.4"
 shortname="jc2"
 gameservername="jc2server"
 commandname="CORE"

tests/tests_mcserver.sh

@@ -20,7 +20,7 @@ if [ -f ".dev-debug" ]; then
 	set -x
 fi
 
-version="v23.3.3"
+version="v23.3.4"
 shortname="mc"
 gameservername="mcserver"
 commandname="CORE"

tests/tests_ts3server.sh

@@ -20,7 +20,7 @@ if [ -f ".dev-debug" ]; then
 	set -x
 fi
 
-version="v23.3.3"
+version="v23.3.4"
 shortname="ts3"
 gameservername="ts3server"
 commandname="CORE"