Browse Source

<label> -> <div> (#7882)

Ref #7646

`<label>` needs to have an HTML input within or a `for=""` attribute

Changes proposed in this pull request:

- fixed 2 `<label>` who are not a 'real' label, so a `<div>` is the better choice


How to test the feature manually:

1. open feed configuration
2. click on "Icon" (first lines of config page) or "Export as OPML" (last lines of config page)
3. nothing will happen. Mouse cursor will not change while hovering over the labels.
maTh 7 months ago
parent
commit
94d4f942d3
1 changed files with 2 additions and 2 deletions
  1. 2 2
      app/views/helpers/feed/update.phtml

+ 2 - 2
app/views/helpers/feed/update.phtml

@@ -52,7 +52,7 @@
 					$this->feed->resetFaviconHash();
 					$ext_url = Minz_ExtensionManager::callHook('custom_favicon_btn_url', $this->feed);
 				?>
-				<label class="group-name"><?= _t('sub.feed.icon') ?></label>
+				<div class="group-name"><?= _t('sub.feed.icon') ?></div>
 				<div class="group-controls">
 					<img class="favicon upload" src="<?= $currentIconUrl ?>" data-initial-src="<?= $currentIconUrl ?>" data-original-icon="<?= $originalIconUrl ?>" alt="✇" loading="lazy" />
 					<div class="favicon-controls">
@@ -890,7 +890,7 @@
 
 	<h2><?= _t('sub.import_export.export') ?></h2>
 	<div class="form-group">
-		<label class="group-name"><?= _t('sub.feed.export-as-opml.label') ?></label>
+		<div class="group-name"><?= _t('sub.feed.export-as-opml.label') ?></div>
 		<div class="group-controls">
 			<a class="btn btn-important" href="<?= _url('index', 'opml', 'get', 'f_' . $this->feed->id()) ?>" download="f_<?= $this->feed->id() ?> <?= $this->feed->name(true) ?>.opml.xml">
 				<?= _t('sub.feed.export-as-opml.download') ?>