Jelajahi Sumber

Fix issue where $keepMax is defaulted to const when non-zero value is compared. (#7416)

Fix issue where $keepMax is defaulted to const when non-zero value is compared.

Fix an issue where $keepMax var is set to ARCHIVING_RETENTION_COUNT_LIMIT
when a user sets "Archiving" -> "Maximum number of articles to keep per
feed" to a non-zero value for a given category.

[EXAMPLE]:
User sets value to 50 (int), This matches the !== comparison and
thus is overridden by ARCHIVING_RETENTION_COUNT_LIMIT.
Bryan Butler 1 tahun lalu
induk
melakukan
3ec0bdab38
1 mengubah file dengan 1 tambahan dan 1 penghapusan
  1. 1 1
      app/Controllers/categoryController.php

+ 1 - 1
app/Controllers/categoryController.php

@@ -113,7 +113,7 @@ class FreshRSS_category_Controller extends FreshRSS_ActionController {
 			} else {
 				if (!Minz_Request::paramBoolean('enable_keep_max')) {
 					$keepMax = false;
-				} elseif (($keepMax = Minz_Request::paramInt('keep_max')) !== 0) {
+				} elseif (($keepMax = Minz_Request::paramInt('keep_max')) === 0) {
 					$keepMax = FreshRSS_Feed::ARCHIVING_RETENTION_COUNT_LIMIT;
 				}
 				if (Minz_Request::paramBoolean('enable_keep_period')) {