*/ private static function entriesFromRss(string $rss): array { $feed = new FreshRSS_Feed('http://example.net/feed.xml', validate: false); $feed->_id(1); $simplePie = new FreshRSS_SimplePieCustom(); $simplePie->enable_cache(false); $simplePie->set_raw_data($rss); self::assertTrue($simplePie->init()); return array_values(iterator_to_array($feed->loadEntries($simplePie))); } public function test_content_dropsUnsafeEnclosureAndThumbnailUrls(): void { $rss = << Malicious feed https://example.net/ Feed with malicious enclosure URLs Victim Article https://example.net/article poc-001 Tue, 14 Nov 2023 20:13:20 +0000 Hello XML; $entries = self::entriesFromRss($rss); self::assertCount(1, $entries); $entry = $entries[0]; self::assertSame('Victim Article', $entry->title()); // The malicious `` of the item must not be stored as an attribute self::assertNull($entry->attributeArray('thumbnail')); // The malicious enclosure must not even be stored as an attribute $enclosureUrls = array_column($entry->attributeArray('enclosures') ?? [], 'url'); self::assertNotContains('javascript:alert(document.domain)//', $enclosureUrls); self::assertContains('https://example.com/podcast.mp3', $enclosureUrls); // SimplePie must absolutise protocol-relative URLs against the feed URL self::assertContains('https://cdn.example.com/podcast2.mp3', $enclosureUrls); $html = $entry->content(); self::assertStringNotContainsString('javascript:', $html); self::assertStringContainsString('href="https://example.com/podcast.mp3"', $html); self::assertStringContainsString('src="https://example.com/thumb.jpg"', $html); self::assertStringContainsString('href="https://cdn.example.com/podcast2.mp3"', $html); self::assertStringContainsString('src="https://cdn.example.com/thumb2.jpg"', $html); self::assertStringContainsString('Hello', $html); } public function test_content_dropsUnsafeUrlsFromLegacyAttributes(): void { $entry = new FreshRSS_Entry(1, 'poc-003', 'Victim Article', '', 'Hello', 'https://example.net/article'); $entry->_attributes([ 'thumbnail' => ['url' => 'javascript:alert(1)'], 'enclosures' => [ ['url' => 'javascript:alert(2)', 'title' => 'evil'], ['url' => 'https://example.com/podcast.mp3', 'thumbnails' => ['javascript:alert(3)', 'https://example.com/thumb.jpg']], ], ]); $html = $entry->content(); self::assertStringNotContainsString('javascript:', $html); self::assertStringContainsString('href="https://example.com/podcast.mp3"', $html); self::assertStringContainsString('src="https://example.com/thumb.jpg"', $html); self::assertStringContainsString('Hello', $html); } /** ZIP/JSON export/import */ public function test_toGReaderFreshRssExportRoundTripsEncoding(): void { $feed = new FreshRSS_Feed('http://example.net/feed.xml', validate: false); $feed->_id(1); $feed->_name('Feed & me'); $entry = new FreshRSS_Entry(1, 'tag:example.net,2026:1', 'A & B', 'B & C', 'Hello', 'https://example.net/post-1', 1731312000); $entry->_id('1731312000000000'); $entry->_feed($feed); $item = $entry->toGReader('freshrss'); self::assertSame('A & B', $item['title']); self::assertSame('B & C', $item['author']); } /** Above PHP_INT_MAX, an integer literal is a float on 32-bit platforms, so an entry ID is only ever a string */ public function test_idRejectsAFloat(): void { $entry = new FreshRSS_Entry(1, 'guid-1', 'Title', '', '', 'https://example.net/1', 1700000000); $this->expectException(\TypeError::class); // @phpstan-ignore argument.type $entry->_id(1700000000000001.0); } /** @return array Content, expected, delimiter (null for the legacy markers) */ public static function provideFullContent(): array { $start = ''; $end = ''; // Original content with copies of the legacy markers inside attribute values, as serialised by libxml2 $original = '

Original

& content'; $cleanOriginal = '

Original

& content'; $cases = []; foreach ([null, '0123456789abcdef0123456789abcdef'] as $delimiter) { $label = $delimiter === null ? 'legacy' : 'delimited'; $separator = $delimiter === null ? '' : " {$delimiter}"; $full = "

Full

"; $unpairedStart = "Full"; $cases = $cases + [ "none $label" => [$cleanOriginal, $cleanOriginal, $delimiter], "prepend $label" => [$full . $original, $original, $delimiter], "append $label" => [$cleanOriginal . $full, $cleanOriginal, $delimiter], "replace $label" => [$full, '', $delimiter], // A lone start marker must not trigger an unsafe cut "unpaired start $label" => [$unpairedStart, $unpairedStart, $delimiter], ]; // (Delimited only) A legacy end comment cannot close a delimited start if ($delimiter !== null) { $cases["legacy end inside $label span"] = [ "Full" . $end . 'x' . "", '', $delimiter, ]; } } return $cases; } #[DataProvider('provideFullContent')] public function test_originalContent_removesFullContent(string $content, string $expected, ?string $delimiter): void { $entry = new FreshRSS_Entry(1, 'guid', 'Title', '', $content, 'https://example.net/article'); if ($delimiter !== null) { $entry->_attribute('full_content_delimiter', $delimiter); } self::assertSame($expected, $entry->originalContent()); } /** * Legacy full-content of legacy entries (unsafe) already in database. */ public function test_loadEntries_withMarkerEchoesInAttributesOfFeed(): void { $rss = <<<'XML' Feed https://example.net/ Article https://example.net/article fullcontent-001 ">Hello

bold]]>
XML; $entries = self::entriesFromRss($rss); self::assertCount(1, $entries); // The legacy markers echoed in attribute values are still detected and cut at ingest self::assertStringNotContainsString('">Hello

& ' . '" \'>bold'; // Freshly fetched content wrapped by loadCompleteContent(), prepended to the original content $full = "

Full

"; $entry = new FreshRSS_Entry(1, 'guid', 'Title', '', $full . $forged, 'https://example.net/article'); $entry->_attribute('full_content_delimiter', $delimiter); // Only the span of the secret unique delimiter is cut; the forged markers are inert self::assertSame($forged, $entry->originalContent()); // Re-parsing the remaining content must not enable any forged element $doc = new DOMDocument(); self::assertTrue($doc->loadHTML('' . $forged, LIBXML_NONET | LIBXML_NOERROR | LIBXML_NOWARNING)); self::assertCount(0, $doc->getElementsByTagName('form')); self::assertSame('p', $doc->getElementsByTagName('p')->item(0)?->nodeName); } }